| From: | Jeff Davis <pgsql(at)j-davis(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: CREATE DATABASE: make LOCALE apply to all collation providers. |
| Date: | 2023-06-17 00:09:28 |
| Message-ID: | 2f4ec2a4e20966474aabce0035ddf939af47fffc.camel@j-davis.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On Fri, 2023-06-16 at 18:06 -0400, Tom Lane wrote:
> You do not get to define that. The reason we have buildfarm members
> running tests this way is exactly to flush out tests that are unduly
> collation-sensitive. They will break in the field too.
It looks like the actual problem is that, when pg_regress creates the
database in --no-locale mode, it passes LC_COLLATE='C' and
LC_CTYPE='C', instead of just LOCALE='C'.
Before my commit, the two were equivalent so it didn't matter, but
afterwards it created an inconsistency that left daticulocale as cs-CZ.
Patch attached.
Regards,
Jeff Davis
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-pg_regress-for-no-locale-use-LOCALE-C.patch | text/x-patch | 1.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2023-06-19 01:01:16 | pgsql: Don't use partial unique indexes for unique proofs in the planne |
| Previous Message | Tom Lane | 2023-06-16 22:06:09 | Re: pgsql: CREATE DATABASE: make LOCALE apply to all collation providers. |