Re: Documentation improvements for partitioning

On 2017/02/13 14:21, Amit Langote wrote:
> On 2017/02/10 19:19, Simon Riggs wrote:
>> * The OID inheritance needs work - you shouldn't need to specify a
>> partition needs OIDS if the parent has it already.
>
> That sounds right. It's better to keep the behavior same as for regular
> inheritance. Will post a patch to get rid of the unnecessary check.
>
> FWIW, the check was added to prevent the command from succeeding in the
> case where WITHOUT OIDS has been specified for a partition and the parent
> partitioned table has the OID column. Regular inheritance simply
> *overrides* the WITHOUT OIDS specification, which might be seen as surprising.

0001 of the attached patches takes care of this.

>> * There's no tab completion, which prevents people from testing this
>> (maybe better now with some docs)
>
> Will post a patch as well.

...and 0002 for this.

>> * ERROR: no partition of relation "measurement_year_month" found for row
>> DETAIL: Failing row contains (2016-12-02, 1, 1).
>> should not return the whole row, just the partition keys
>
> I think that makes sense. Something along the lines of
> BuildIndexValueDescription() for partition keys will be necessary. Will
> post a patch.

Let me spend a bit more time on this one.

Thanks,
Amit