From: | Victor Drobny <v(dot)drobny(at)postgrespro(dot)ru> |
---|---|
To: | Aleksander Alekseev <a(dot)alekseev(at)postgrespro(dot)ru> |
Cc: | Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Red-Black tree traversal tests |
Date: | 2017-08-02 12:13:04 |
Message-ID: | 2e864bd9888f41f7f6c9808ee2b8a5a0@postgrespro.ru |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hello,
Thank you for the reviewing.
>> If it's not too much trouble perhaps you could write a few more test
>> so
>> we would have 100% test coverage for rbtree, could modify it safely
>> and
>> be sure that it actually works when someone will need the rest of its
>> functionality?
Done. Now all of the functions in rbtree.c are covered.
> Also I would recommend to add your patch to the nearest commitfest [1].
> Otherwise there is a good chance that everyone will forget about it
> quite soon.
>
> [1]: https://commitfest.postgresql.org/14/
Done. Here is the link: https://commitfest.postgresql.org/14/1225/
Thank you for attention!
--
------
Victor Drobny
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
From | Date | Subject | |
---|---|---|---|
Next Message | Victor Drobny | 2017-08-02 12:15:32 | Re: Red-Black tree traversal tests |
Previous Message | Daniel Verite | 2017-08-02 12:00:49 | Re: Crash report for some ICU-52 (debian8) COLLATE and work_mem values |