Re: restore PD_PAGE_FULL on WAL update replay

From: "Pavan Deolasee" <pavan(dot)deolasee(at)gmail(dot)com>
To: "Alvaro Herrera" <alvherre(at)commandprompt(dot)com>
Cc: "Pg Hackers" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: restore PD_PAGE_FULL on WAL update replay
Date: 2008-11-08 07:35:27
Message-ID: 2e78013d0811072335q4fa0933akf1ac470219d89b19@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Nov 7, 2008 at 9:12 PM, Alvaro Herrera
<alvherre(at)commandprompt(dot)com> wrote:
> This patch ensures that the PD_PAGE_FULL bit is restored after replaying
> a heap_update WAL record. I think this must have been overlooked on the
> HOT patch.
>
>

Since PD_PAGE_FULL is just a hint, I think we might have deliberately
left it that way. Even if we want to fix this, we should also replay
the action of clearing the bit in heap_xlog_clean()

Thanks,
Pavan

--
Pavan Deolasee
EnterpriseDB http://www.enterprisedb.com

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Benedek László 2008-11-08 08:25:26 Re: pg_dump roles support
Previous Message KaiGai Kohei 2008-11-08 05:25:08 Re: Updates of SE-PostgreSQL 8.4devel patches (r1197)