| From: | "Pavan Deolasee" <pavan(dot)deolasee(at)gmail(dot)com> |
|---|---|
| To: | "Zdenek Kotala" <Zdenek(dot)Kotala(at)sun(dot)com> |
| Cc: | PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: page macros cleanup |
| Date: | 2008-07-03 11:50:52 |
| Message-ID: | 2e78013d0807030450m4cab60d0jd99d1acce59fae56@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
On Fri, Jun 13, 2008 at 9:38 PM, Zdenek Kotala <Zdenek(dot)Kotala(at)sun(dot)com> wrote:
> I attached code cleanup which is related to in-place upgrade. I replace
> direct access to PageHeader structure with already existing macros and I
> removed also unnecessary retyping.
A quick review comment:
One thing I noticed is that the modified definition of HashMaxItemSize
now does not account for the size of ItemId which may not be the right
thing. Please recheck that.
Apart from that the patch looks good to me. As you said, we should
probably replace the other direct usage of PageHeader with appropriate
macros.
Thanks,
Pavan
--
Pavan Deolasee
EnterpriseDB http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | daveg | 2008-07-03 12:55:01 | Re: [PATCHES] pg_dump lock timeout |
| Previous Message | Markus Wanner | 2008-07-03 08:32:54 | Re: Regression test database name |