Re: [pgsql-patches] Ctid chain following enhancement

From: "Pavan Deolasee" <pavan(dot)deolasee(at)gmail(dot)com>
To: "Zdenek Kotala" <Zdenek(dot)Kotala(at)sun(dot)com>
Cc: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-patches(at)postgresql(dot)org
Subject: Re: [pgsql-patches] Ctid chain following enhancement
Date: 2007-05-30 13:27:01
Message-ID: 2e78013d0705300627w32a7afedr28fd44a3159aaef4@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

On 5/29/07, Zdenek Kotala <Zdenek(dot)Kotala(at)sun(dot)com> wrote:
>
>
> I'm looking on your patch. I have one comment:
>
> If you have old tid and new tid you can easy compare if new tid points
> to different page? And if page is still same there is no reason to
> Unlock it and lock again. I think add inner loop something like:
>
>
Tom has already expressed his unwillingness to add complexity
without any proven benefits. Your suggestion though good would
make the code more unreadable without much benefit since the
function is not called very often.

Thanks,
Pavan

--
Pavan Deolasee
EnterpriseDB http://www.enterprisedb.com

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Magnus Hagander 2007-05-30 13:27:40 Re: msvc, build and install with cygwin in the PATH
Previous Message Hannes Eder 2007-05-30 11:56:24 Re: msvc, build and install with cygwin in the PATH