Re: CIC and deadlocks

From: "Pavan Deolasee" <pavan(dot)deolasee(at)gmail(dot)com>
To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: CIC and deadlocks
Date: 2007-03-31 18:21:58
Message-ID: 2e78013d0703311121u43dacd82x8a7bc7b537798da9@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

On 3/31/07, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
>
> Hmm ... only if it's already set inVacuum true ... there's a window
> where it has not.
>
> I wonder whether we could change CIC so that the "reference
> snapshot" lists only transactions that are running and have already
> determined their serializable snapshot (ie, have set proc->xmin).
> Xacts that haven't yet done that can be ignored because they couldn't
> possibly see the dead tuples we're worried about, no?

Yes, it may work. Do we need to take some extra care because
proc-xmin is set while holding SHARED lock on proc array ?

Then we could rearrange the order of operations in vacuum_rel so
> that we lock the target rel before we acquire a snapshot. Then
> a vacuum waiting for the CIC cannot cause a deadlock.

We may need to do the same in analyze_rel.

Thanks,
Pavan

--

EnterpriseDB http://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2007-03-31 18:32:18 Re: Oracle indemnifies PostgreSQL on its patents
Previous Message Joshua D. Drake 2007-03-31 18:01:35 Re: Oracle indemnifies PostgreSQL on its patents

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2007-03-31 19:00:40 Re: CIC and deadlocks
Previous Message Tom Lane 2007-03-31 17:33:15 Re: CIC and deadlocks