| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Small TAP tests cleanup for Windows and unused modules |
| Date: | 2022-02-16 22:04:01 |
| Message-ID: | 2e523a9e-d82f-0bb0-f4c1-bd5525e0c7a7@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2/16/22 16:36, Daniel Gustafsson wrote:
> Seeing msys in TAP tests mentioned in a thread [1] tonight reminded me about
> two related (well, one of them) patches I had sitting around, so rather than
> forgetting again here are some small cleanups.
>
> 0001 attempts to streamline how we detect Windows in the TAP tests (after that
> there is a single msys check left that I'm not sure about, but [1] seems to
> imply it could go); 0002 removes some unused module includes which either were
> used at some point in the past or likely came from copy/paste.
>
0002 looks OK at first glance.
0001 is something we should investigate. It's really going in the wrong
direction I suspect. We should be looking to narrow the scope of these
platform-specific bits of processing, not expand them.
cheers
andrew
--
Andrew Dunstan
EDB: https://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2022-02-16 22:29:21 | Re: Small TAP tests cleanup for Windows and unused modules |
| Previous Message | Peter Geoghegan | 2022-02-16 21:47:39 | Re: do only critical work during single-user vacuum? |