Re: [PATCH] Change simple_heap_insert() to a macro

From: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
To: Andrey Klychkov <aaklychkov(at)mail(dot)ru>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Change simple_heap_insert() to a macro
Date: 2018-11-02 11:08:09
Message-ID: 2e0e9725-607b-abdf-b809-3b9265b8d581@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 12/10/2018 12:09, Andrey Klychkov wrote:
> I don't see any reasons against to use the proposed macro instead of
> this function.

Macros are weird and should be avoided if possible. If we were to do
this, it should be an inline function, I think. But I think it's not
useful here.

I think there have been enough votes against this that I'll close this
CF item.

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Stephen Frost 2018-11-02 11:08:35 Re: WIP Patch: Add a function that returns binary JSONB as a bytea
Previous Message Stephen Frost 2018-11-02 10:47:19 Re: INSTALL file