remove pgrminclude?

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: remove pgrminclude?
Date: 2024-12-09 07:14:54
Message-ID: 2d4dc7b2-cb2e-49b1-b8ca-ba5f7024f05b@eisentraut.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I propose to remove the pgrminclude scripts and annotations. AFAICT,
per git log, the last time someone tried to do something with it was
around 2011. Also, many (not all) of the "pgrminclude ignore"
annotations are of a newer date but seem to have just been copied around
during refactorings and file moves and don't seem to reflect an actual
need anymore.

I think the include-what-you-use tool that I've been using lately is a
better tool and can adequately replace pgrminclude.

I'm sending separately a patch to add some IWYU annotations, but these
don't seem to correspond very strongly to pgrminclude annotations, so I
don't see any value in keeping the old ones even for a transition.

Here are the scripts to remove:
1. pgcheckdefines -- This could still be useful???
2. pgcominclude -- redundant with headerscheck
3. pgdefine -- used internally only
4. pgfixinclude -- Could still be useful principle?
5. pgrminclude -- obsolete

Attachment Content-Type Size
0001-Remove-pgrminclude-annotations.patch text/plain 7.7 KB
0002-Remove-pgrminclude-and-associated-scripts.patch text/plain 19.1 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Yugo NAGATA 2024-12-09 07:20:28 Re: Assert failure on running a completed portal again
Previous Message Amit Langote 2024-12-09 07:10:24 Re: generic plans and "initial" pruning