Re: Refactoring postmaster's code to cleanup after child exit

On 3/7/25 15:53, Andres Freund wrote:
> Hi,
>
> On 2025-03-06 22:49:20 +0200, Heikki Linnakangas wrote:
>> In short, all the 4 patches look good to me. Thanks for picking this up!
>>
>> On 06/03/2025 22:16, Andres Freund wrote:
>>> On 2025-03-05 20:49:33 -0800, Noah Misch wrote:
>>>>> This behaviour makes it really hard to debug problems. It'd have been a lot
>>>>> easier to understand the problem if we'd seen psql's stderr before the test
>>>>> died.
>>>>>
>>>>> I guess that mean at the very least we'd need to put an eval {} around the
>>>>> ->pump() call., print $self->{stdout}, ->{stderr} and reraise an error?
>>>>
>>>> That sounds right.
>>>
>>> In the attached patch I did that for wait_connect(). I did verify that it
>>> works by implementing the wait_connect() fix before fixing
>>> 002_connection_limits.pl, which fails if a sleep(1) is added just before the
>>> proc_exit(1) for FATAL.
>>
>> +1. For the archives sake, I just want to clarify that this pump stuff is
>> all about getting better error messages on a test failure. It doesn't help
>> with the original issue.
>
> Agreed.
>

FWIW I keep running into this (and skink seems unhappy too). I ended up
just adding a sleep(1), right before

push(@sessions, background_psql_as_user('regress_superuser'));

and that makes it work on all my machines (including rpi5).

regards

--
Tomas Vondra