Re: pgsql: doc: improve build for non-Latin1 characters

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: Bruce Momjian <bruce(at)momjian(dot)us>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: doc: improve build for non-Latin1 characters
Date: 2024-11-04 07:02:18
Message-ID: 2c5dd601-b245-4092-9c27-6d1ad51609df@eisentraut.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-docs

I'm surprised this was committed. I don't think there was consensus
that this is the right direction. Moreover, this touched a couple of
files that it shouldn't have:

doc/src/sgml/images/genetic-algorithm.svg is a generated file that
shouldn't be changed directly. In fact, adding the *.svg files to the
check-nbsp target is therefore also wrong.

The chunk in doc/src/sgml/stylesheet-man.xsl was copied from the
upstream stylesheets, and changing it causes extra differences that
would make future maintenance harder. Also, man stylesheets have by
definition nothing to do with the pdf builds, so why do they need to be
touched?

I continue to think the whole premise of this patch is wrong.

On 01.11.24 17:47, Bruce Momjian wrote:
> doc: improve build for non-Latin1 characters
>
> Add README.non-ASCII to explain non-ASCII doc behavior; some text moved
> from release.sgml.
>
> Change UTF8 SGML characters to use HTML entities.
>
> Remove unnecessary UTF8 spaces.
>
> Add SVG file check for check-nbsp target.
>
> Add dummy 'pdf' Makefile target.
>
> Reported-by: Yugo Nagata
>
> Discussion: https://postgr.es/m/20241011114122.c90f8a871462da36f2e2afeb@sraoss.co.jp
>
> Backpatch-through: master
>
> Branch
> ------
> master
>
> Details
> -------
> https://git.postgresql.org/pg/commitdiff/641a5b7a1447954076728f259342c2f9201bb0b5
>
> Modified Files
> --------------
> doc/src/sgml/Makefile | 11 ++++-----
> doc/src/sgml/README.non-ASCII | 37 +++++++++++++++++++++++++++++++
> doc/src/sgml/charset.sgml | 10 ++++-----
> doc/src/sgml/images/genetic-algorithm.svg | 4 ++--
> doc/src/sgml/release.sgml | 18 ---------------
> doc/src/sgml/stylesheet-man.xsl | 12 +++++-----
> 6 files changed, 56 insertions(+), 36 deletions(-)
>

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Heikki Linnakangas 2024-11-04 12:25:37 pgsql: Add PG_TEST_EXTRA configure option to the Make builds
Previous Message Michael Paquier 2024-11-04 06:04:09 Re: pgsql: Implement pg_wal_replay_wait() stored procedure

Browse pgsql-docs by date

  From Date Subject
Next Message Bruce Momjian 2024-11-04 19:52:57 Re: pgsql: doc: improve build for non-Latin1 characters
Previous Message jian he 2024-11-03 13:58:00 Re: Tip box on Adding a Column