| From: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz>, Ranier Vilela <ranier(dot)vf(at)gmail(dot)com> |
| Cc: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Small miscellaneous fixes |
| Date: | 2022-11-25 12:15:40 |
| Message-ID: | 2c2c9f2a-cf29-1ec2-b6d8-f23c6ccbb3a1@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 04.10.22 06:18, Michael Paquier wrote:
> On Mon, Oct 03, 2022 at 08:05:57AM -0300, Ranier Vilela wrote:
>> Em seg., 3 de out. de 2022 às 05:01, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
>> escreveu:
>>> On Fri, Sep 30, 2022 at 9:08 AM Ranier Vilela <ranier(dot)vf(at)gmail(dot)com> wrote:
>>>> 1. Avoid useless reassigning var _logsegno
>>> (src/backend/access/transam/xlog.c)
>>>> Commit 7d70809 left a little oversight.
>>>> XLByteToPrevSeg and XLByteToSeg are macros, and both assign _logsegno.
>>>> So, the first assignment is lost and is useless.
>
> Right, I have missed this one. We do that now in
> build_backup_content() when building the contents of the backup
> history file.
Is this something you want to follow up on, since you were involved in
that patch? Is the redundant assignment simply to be deleted, or do you
want to check the original patch again for context?
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2022-11-25 12:19:18 | Re: [PATCH] Add initial xid/mxid/mxoff to initdb |
| Previous Message | Daniel Gustafsson | 2022-11-25 12:13:50 | Re: Does pg_rman support PG15? |