Re: psql: Make SSL info display more compact

From: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: psql: Make SSL info display more compact
Date: 2022-03-01 08:44:29
Message-ID: 2b91fbb3-5b49-aec6-22ba-d1cb57185aa4@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 28.02.22 16:12, Tom Lane wrote:
> Daniel Gustafsson <daniel(at)yesql(dot)se> writes:
>> On 28 Feb 2022, at 12:56, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> wrote:
>>> On 28.02.22 11:50, Dagfinn Ilmari Mannsåker wrote:
>>>> How about making it show "compression: on" if compression is on, but
>>>> nothing in the common "off" case?
>
>>> That would work for me.
>
>> On POLA grounds I would prefer to never to show it. If we ever get libpq
>> compression and want to show that, I'd prefer that we didn't end up
>> "compression" meaning one thing except when it means two things.
>
> Well, any such output would presumably be on a different line and
> thus distinguishable from the SSL property; plus, it'd be impossible
> for both forms to show up in the same connection.
>
> However, how about writing "SSL compression: on" versus writing
> nothing? That avoids doubt about what it means. I don't buy
> Michael's argument that this is ambiguous, either.

I didn't mean to reopen the whole SSL compression can of worms here, I
was mistaken about the level of support left after PG14. I was merely
lightly annoyed that the psql startup display got quite long with not
very interesting information.

I propose a reduced patch that just removes the "bits" display, since
that is redundant with the "cipher" display.

Attachment Content-Type Size
v2-0001-psql-Make-SSL-info-display-more-compact.patch text/plain 1.3 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro Horiguchi 2022-03-01 08:50:30 Re: In-placre persistance change of a relation
Previous Message Michael Paquier 2022-03-01 08:04:35 Re: Add LZ4 compression in pg_dump