From: | Joe Conway <mail(at)joeconway(dot)com> |
---|---|
To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: string literal continuations in C |
Date: | 2019-12-24 11:43:20 |
Message-ID: | 2b835739-d518-a0cb-7b7e-08ff232279c9@joeconway.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 12/23/19 2:51 PM, Alvaro Herrera wrote:
> Per a recent thread, these patches remove string literals split with
> \-escaped newlines. The first is for the message "materialize mode
> required, but it is not allowed in this context" where it's more
> prevalent, and we keep perpetuating it; the second is for other
> messages, whose bulk is in dblink and tablefunc. I think the split is
> pointless and therefore propose to push both together as a single
> commit, but maybe somebody would like me to leave those contrib modules
> alone.
I take it since I was explicitly CC'd that the contrib comment was aimed
at me? I likely copied the convention from somewhere else in the
backend, but I don't care either way if you want to change them. However
I guess we should coordinate since I've been berated regarding error
codes and will likely go change at least two of them in tablefunc soon
(not likely before Thursday though)...
Joe
--
Crunchy Data - http://crunchydata.com
PostgreSQL Support for Secure Enterprises
Consulting, Training, & Open Source Development
From | Date | Subject | |
---|---|---|---|
Next Message | Prabhat Sahu | 2019-12-24 11:59:25 | Server crash with Master-Slave configuration. |
Previous Message | Mahendra Singh | 2019-12-24 11:20:58 | Assert failure due to "drop schema pg_temp_3 cascade" for temporary tables and \d+ is not showing any info after drooping temp table schema |