Re: Some dead code in get_param_path_clause_serials()

From: Andrei Lepikhov <lepihov(at)gmail(dot)com>
To: Richard Guo <guofenglinux(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Some dead code in get_param_path_clause_serials()
Date: 2024-11-13 12:59:04
Message-ID: 2af59bbf-b9c0-4e1d-b706-a1b1135b62c8@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 11/13/24 16:34, Richard Guo wrote:
> The function get_param_path_clause_serials() is used to get the set of
> pushed-down clauses enforced within a parameterized Path. Since we
> don't currently support parameterized MergeAppend paths, and it
> doesn't look like that is going to change anytime soon (as explained
> in the comments for generate_orderedappend_paths), we don't need to
> consider MergeAppendPath in this function. Is it worth removing the
> related code, as attached?
>
> This change won't make any measurable difference in performance; it's
> just for clarity's sake.
I've passed through the logic of
get_param_path_clause_serials/reparameterize_path_by_child/reparameterize_path.
Agree, it seems not useful to parameterise ordered appends in the near
future. Even So, it would be better to insert changes, induced by new
feature by one commit.
By the way, Do you know if anyone gave a speech on the current state of
internal plan parameterisation and its possible development directions?
It would be helpful to have such an explanation.

--
regards, Andrei Lepikhov

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Yugo NAGATA 2024-11-13 13:02:35 Re: Change COPY ... ON_ERROR ignore to ON_ERROR ignore_row
Previous Message jian he 2024-11-13 12:56:59 Re: altering a column's collation leaves an invalid foreign key