| From: | Nikita Glukhov <n(dot)gluhov(at)postgrespro(dot)ru> |
|---|---|
| To: | David Steele <david(at)pgmasters(dot)net>, Haozhou Wang <hawang(at)pivotal(dot)io>, Anthony Bykov <a(dot)bykov(at)postgrespro(dot)ru> |
| Cc: | pgsql-hackers(at)postgresql(dot)org, Paul Guo <pguo(at)pivotal(dot)io>, Hubert Zhang <hzhang(at)pivotal(dot)io> |
| Subject: | Re: [PATCH] Add missing type conversion functions for PL/Python |
| Date: | 2018-03-26 16:07:47 |
| Message-ID: | 2a821a6e-3e27-8926-2214-42dd55960909@postgrespro.ru |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 26.03.2018 17:19, David Steele wrote:
> On 2/20/18 10:14 AM, Haozhou Wang wrote:
>> Thank you very much for your review!
>>
>> I attached a new patch with typo fixed.
> I think it's a bit premature to mark this Ready for Committer after a
> review consisting of a few typos. Anthony only said that he started
> looking at it so I've marked it Needs Review.
Hi.
I also have looked at this patch and found some problems.
Attached fixed 3th version of the patch:
* initialization of arg->u.scalar was moved into PLy_output_setup_func()
* added range checks for int16 and int32 types
* added subroutine PLyInt_AsLong() for correct handling OverflowError that can
be thrown from PyInt_AsLong()
* casting from Python float to PostgreSQL numeric using PyFloat_AsDouble() was
removed because it can return incorrect result for Python long and
float8_numeric() uses float8 and numeric I/O functions
* fixed whitespace
--
Nikita Glukhov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Add-missing-type-conversion-functions-for-PL-Python-v3.patch | text/x-patch | 6.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Vladimir Sitnikov | 2018-03-26 16:09:04 | Re: Proposal: http2 wire format |
| Previous Message | Simon Riggs | 2018-03-26 16:06:10 | Re: [HACKERS] MERGE SQL Statement for PG11 |