| From: | Sami Imseih <samimseih(at)gmail(dot)com> |
|---|---|
| To: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Cc: | Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Restart pg_usleep when interrupted |
| Date: | 2024-07-11 18:10:25 |
| Message-ID: | 2F781744-69B8-4BC2-A6EF-3998DCCDB634@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
>
> I'm curious why we wouldn't just subtract "elapsed_time" from "delay" at
> the bottom of the while loop to avoid needing this extra check.
Can you elaborate further? I am not sure how this will work since delay is a timespec
and elapsed time is an instr_time.
Also, in every iteration of the loop, the delay must be set to the remaining time. The
purpose of the elapsed_time is to make sure that we don’t surpass requested time
delay as an additional safeguard.
> Also, I
> think we need some commentary about why we want to retry after an interrupt
> in this case.
I will elaborate further in the comments for the next revision.
Regards,
Sami
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2024-07-11 19:56:44 | Re: Restart pg_usleep when interrupted |
| Previous Message | Robert Haas | 2024-07-11 18:00:09 | Re: Add a GUC check hook to ensure summarize_wal cannot be enabled when wal_level is minimal |