From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
---|---|
To: | Peter Smith <smithpb2250(at)gmail(dot)com> |
Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: GUC names in messages |
Date: | 2023-11-01 09:23:22 |
Message-ID: | 2D257B05-C1BC-4F99-B956-A0D5A03C15E3@yesql.se |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
> On 1 Nov 2023, at 10:02, Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
> GUC_check_errdetail("effective_io_concurrency must be set to 0 on
> platforms that lack posix_fadvise().");
> src/backend/commands/variable.c:
> GUC_check_errdetail("maintenance_io_concurrency must be set to 0 on
> platforms that lack posix_fadvise().");
These should be substituted to reduce the number of distinct messages that need
to be translated. I wouldn't be surprised if more like these have slipped
through.
> I had intended to make a patch to address the inconsistency, but
> couldn't decide which of those styles was the preferred one.
Given the variety in the codebase I don't think there is a preferred one.
> Then I worried this could be the tip of the iceberg
All good rabbit-holes uncovered during hacking are.. =)
> Ideally, they should all look the same everywhere, shouldn't they?
Having a policy would be good, having one which is known and enforced is even
better (like how we are consistent around error messages based on our Error
Message Style Guide).
--
Daniel Gustafsson
From | Date | Subject | |
---|---|---|---|
Next Message | Xing Guo | 2023-11-01 09:25:42 | Don't pass NULL pointer to strcmp(). |
Previous Message | Peter Smith | 2023-11-01 09:22:30 | Re: GUC names in messages |