From: | Pramod Ahire <pramod(dot)ahire(at)enterprisedb(dot)com> |
---|---|
To: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
Cc: | Nagesh Dhope <nagesh(dot)dhope(at)enterprisedb(dot)com>, Postgres Enterprise Manager <pem(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: CSS SonarQube fixes |
Date: | 2020-07-03 12:02:31 |
Message-ID: | 2CEE8E27-AC6F-4045-9F70-764C27565C89@enterprisedb.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi Akshay,
Attached updated patch, can you try & let me know if it works ?
@Nagesh Please commit the patch for PEM earlier sent over email, as wizard css changes are not for pgadmin excluded it in latest patch.
Thanks & sorry for the inconvenience.
Pramod Ahire
Software Engineer
C: +91-020-66449600/601
D: +91-9028697679
From: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
Date: Friday, 3 July 2020 at 3:34 PM
To: Pramod Ahire <pramod(dot)ahire(at)enterprisedb(dot)com>
Cc: Nagesh Dhope <nagesh(dot)dhope(at)enterprisedb(dot)com>, Postgres Enterprise Manager <pem(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: CSS SonarQube fixes
Not able to apply the patch.
On Fri, Jul 3, 2020 at 12:15 PM Pramod Ahire <pramod(dot)ahire(at)enterprisedb(dot)com> wrote:
Hi Nagesh,
Done the changes as you suggested, please find attached patch for same.
Also coping pgadmin-hackers for integration.
Thanks & feel free to let me know, if missed anything.
Pramod Ahire
Software Engineer
C: +91-020-66449600/601
D: +91-9028697679
From: Nagesh Dhope <nagesh(dot)dhope(at)enterprisedb(dot)com>
Date: Wednesday, 1 July 2020 at 10:57 AM
To: Pramod Ahire <pramod(dot)ahire(at)enterprisedb(dot)com>
Cc: Postgres Enterprise Manager <pem(at)enterprisedb(dot)com>
Subject: Re: CSS SonarQube fixes
Hi Pramod,
Remove commented styles from below files.
web/pgadmin/misc/file_manager/static/css/file_manager.css
web/pgadmin/misc/file_manager/static/scss/_file_manager.scss
web/pgadmin/misc/static/explain/scss/_explain.scss
Apart from this, the patch looks good. Please send the updated patch to pgadmin-hackers(at)postgresql(dot)org(dot)
On Tue, Jun 30, 2020 at 4:44 PM Nagesh Dhope <nagesh(dot)dhope(at)enterprisedb(dot)com> wrote:
Hi Team,
I am reviewing this patch.
On Mon, Jun 29, 2020 at 4:54 PM Pramod Ahire <pramod(dot)ahire(at)enterprisedb(dot)com> wrote:
Hi Team,
Please find few CSS fixes for SonarQube.
It consists below types of issues:
Duplicate CSS removal
Few standard syntax applied on classes
Double semicolon removal
Other minor
Had tested at my end, & verified. Please do let me know if missed anything thanks !
Pramod Ahire
Software Engineer
C: +91-020-66449600/601
D: +91-9028697679
--
Thanks,
Nagesh
--
Thanks,
Nagesh
--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246
Attachment | Content-Type | Size |
---|---|---|
SONAR_CSS_FIXES_PGADMIN.patch | application/octet-stream | 3.7 KB |
![]() |
image/png | 68.4 KB |
![]() |
image/png | 68.4 KB |
![]() |
image/png | 68.4 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Akshay Joshi | 2020-07-03 13:16:33 | Re: CSS SonarQube fixes |
Previous Message | Murtuza Zabuawala | 2020-07-03 11:37:32 | Re: pgAdmin 4 commit: Added support for schema level restriction. Fixes #55 |