Re: [pgsql-packagers] Palle Girgensohn's ICU patch

From: Jakob Egger <jakob(at)eggerapps(dot)at>
To: Palle Girgensohn <girgen(at)pingpong(dot)net>
Cc: Magnus Hagander <magnus(at)hagander(dot)net>, "pgsql-packagers(at)postgresql(dot)org" <pgsql-packagers(at)postgresql(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Bussmann Tobias <tobias(dot)bussmann(at)scnat(dot)ch>
Subject: Re: [pgsql-packagers] Palle Girgensohn's ICU patch
Date: 2014-11-26 09:36:17
Message-ID: 2BC2B388-6500-4CFF-94BB-3FACBBE9F6B1@eggerapps.at
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> One of the
> big arguments against bringing it in then (because it worked) was that
> we'd bring in another compile time dependency that's actually larger
> than PostgreSQL itself.

Magnus: I don't see how this is a problem as long as using ICU is *optional*. On systems with a working strcoll there is no problem with using the stdc functions (except that ICU might offer more collations).

> Jakob, including the patch in PostgreSQL.app seems pretty reasonable. There's is only a small fraction of ICU that is used, a couple of libraries I believe.

Palle: The ICU libraries themselves aren't that big, but the required data files (also packaged as a dynamic library) are big (around 25MB uncompressed). However, I'd rather increase the download size by 30% than ship a broken database.

Best regards,
Jakob

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Palle Girgensohn 2014-11-26 09:45:53 Re: [pgsql-packagers] Palle Girgensohn's ICU patch
Previous Message Heikki Linnakangas 2014-11-26 09:22:08 Re: PITR failing to stop before DROP DATABASE