| From: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, David Rowley <dgrowleyml(at)gmail(dot)com>, Melanie Plageman <melanieplageman(at)gmail(dot)com>, Konstantin Knizhnik <knizhnik(at)garret(dot)ru>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Subject: | Re: Sync scan & regression tests |
| Date: | 2023-09-19 09:06:57 |
| Message-ID: | 29c74104-210b-ef39-2522-27a6aa7a704f@iki.fi |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 19/09/2023 01:57, Andres Freund wrote:
> On 2023-09-18 13:49:24 +0300, Heikki Linnakangas wrote:
>> d) Copy fewer rows to the table in the test. If we copy only 6 rows, for
>> example, the table will have only two pages, regardless of shared_buffers.
>>
>> I'm leaning towards d). The whole test is a little fragile, it will also
>> fail with a non-default block size, for example. But c) seems like a simple
>> fix and wouldn't look too out of place in the test.
>
> Hm, what do you mean with the last sentence? Oh, is the test you're
> referencing the relation-extension logic?
Sorry, I said "c) seems like a simple fix ...", but I meant "d) seems
like a simple fix ..."
I meant the attached.
--
Heikki Linnakangas
Neon (https://neon.tech)
| Attachment | Content-Type | Size |
|---|---|---|
| silence-small-shared_buffers-fail-by-changing-test-to-copy-less.patch | text/x-patch | 943 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | bt23nguyent | 2023-09-19 09:21:59 | Re: Improve the log message output of basic_archive when basic_archive.archive_directory parameter is not set |
| Previous Message | Ryoga Yoshida | 2023-09-19 08:59:11 | Fix bug in VACUUM and ANALYZE docs |