Re: Another XML build issue

Kevin Grittner <kgrittn(at)gmail(dot)com> writes:
> Today, on my ubuntu 14.04 LTS system, I saw an XML change come through
> with updates. My build on master is now broken with this:

> - line 1: Start tag expected, '<' not found
> -
> - ^

Now that I look more closely, there are really two distinct pathologies
exhibited in xml_2.out. One is what I said in the commit message, that
error position reports occurring at EOF are lost. But the other is
that this specific error message disappears altogether. Looking at the
larger context:

SELECT xmlparse(document '');
ERROR: invalid XML document
DETAIL: line 1: switching encoding : no input

^
line 1: Document is empty

^
line 1: Start tag expected, '<' not found

^

the missing message is one that should have come out after the "document
is empty" message. I am suspicious that what this is is an additional
side effect of the CVE-2015-7499 fix, which as I understood it was a hack
to prevent further parsing once any error has been detected.

So at this point I'm guessing that Ubuntu has shipped an update that
includes the patch Pavel Raiskup suggested in

https://bugzilla.redhat.com/show_bug.cgi?id=1286692#c4

which would fix the lack of error cursors at EOF, but it would not affect
any larger change such as stopping after the first detected error.

If you can confirm that, then we'll need to decide what to do about it.
Personally I'd vote for just dropping this specific test case, which
does not seem to have enough value to justify carrying YA expected-file.

regards, tom lane