From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Victor Drobny <v(dot)drobny(at)postgrespro(dot)ru> |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: A mistake in a comment |
Date: | 2017-06-26 13:54:04 |
Message-ID: | 29896.1498485244@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Victor Drobny <v(dot)drobny(at)postgrespro(dot)ru> writes:
> I believe that I have found a mistake in a comment to
> parse_phrase_operator function. The comment has the following line:
> a <X> b (distance is no greater than X)
> which is not. According to documentation and practical results, this
> line should me changed on something like:
> a <X> b (distance is equal to X)
Ah, this comment got missed when we changed the definition of <N>.
> Patch in the attachments fixes the issue.
Will apply, thanks. Looks to me like there's an outright bug here
as well: if errno happened to already be ERANGE when we reach the
strtol() call, the code will incorrectly report an error.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Joel Jacobson | 2017-06-26 14:00:55 | \set AUTOROLLBACK ON |
Previous Message | Jeevan Ladhe | 2017-06-26 11:30:15 | Re: fix empty array expression in get_qual_for_list() |