From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | John Lumby <johnlumby(at)hotmail(dot)com> |
Cc: | pgsql-docs(at)postgresql(dot)org |
Subject: | Re: Cannot build docs on Ubuntu 10.04? |
Date: | 2012-03-14 14:21:55 |
Message-ID: | 29895.1331734915@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-docs |
John Lumby <johnlumby(at)hotmail(dot)com> writes:
> On 12-01-2012 17:28, Josh Berkus wrote:
> I wonder if everyone noticed that the postgres sgml makefile is looking for the script in /bin
> (see Josh's append)
That means that configure failed to find it, and failed to determine
a setting for DOCBOOKSTYLE as well.
> I think this line in
> postgresql-9.1.3/doc/src/sgml/Makefile
> COLLATEINDEX = $(DOCBOOKSTYLE)/bin/collateindex.pl
> could be improved - maybe should read
> COLLATEINDEX = `which collateindex.pl`
No, that would not be an improvement. If collateindex.pl were in your
PATH, then configure would have found it (cf PGAC_PATH_COLLATEINDEX),
and so COLLATEINDEX would be set and we'd not be here at all.
Maybe the Makefile should just error out if COLLATEINDEX isn't set,
rather than trying a "fallback" value that configure has already
determined isn't going to work.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | John Lumby | 2012-03-14 17:47:18 | Re: Cannot build docs on Ubuntu 10.04? |
Previous Message | Alvaro Herrera | 2012-03-14 14:13:39 | Re: Cannot build docs on Ubuntu 10.04? |