Re: Re: Doc patch making firm recommendation for setting the value of commit_delay

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Noah Misch <noah(at)leadboat(dot)com>
Cc: Peter Geoghegan <peter(dot)geoghegan86(at)gmail(dot)com>, PG Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Re: Doc patch making firm recommendation for setting the value of commit_delay
Date: 2013-03-15 21:47:30
Message-ID: 29881.1363384050@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Noah Misch <noah(at)leadboat(dot)com> writes:
> I'm marking this patch Ready for Committer, qualified with a recommendation to
> adopt only the wal.sgml changes.

I've committed this along with some further wordsmithing. I kept
Peter's change to pg_test_fsync's default -s value; I've always felt
that 2 seconds was laughably small. It might be all right for very
quick-and-dirty tests, but as a default value, it seems like a poor
choice, because it's at the very bottom of the credible range of
choices.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David E. Wheeler 2013-03-15 21:56:32 Should array_length() Return NULL
Previous Message Bruce Momjian 2013-03-15 21:15:19 Re: pg_test_fsync crashes on systems with POSIX signal handling