Re: patch: remove redundant code from pl_exec.c

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: patch: remove redundant code from pl_exec.c
Date: 2010-12-17 15:35:54
Message-ID: 29866.1292600154@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> writes:
> 2010/12/17 Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>:
>> I'm not really impressed with this idea: there's no a priori reason
>> that all those loop types would necessarily have exactly the same
>> control logic.

> There is no reason why the processing should be same, but actually is same.

Yes, and it might need to be different in future, whereupon this patch
would make life extremely difficult.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2010-12-17 15:41:06 Re: ps_status on fastpath
Previous Message Pavel Stehule 2010-12-17 15:33:09 Re: proposal: FOREACH-IN-ARRAY (probably for 9.2?)