Re: parallel.c oblivion of worker-startup failures

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: parallel.c oblivion of worker-startup failures
Date: 2017-09-18 16:30:44
Message-ID: 29845.1505752244@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> writes:
> Attached patch fixes these problems.

Hmm, this patch adds a kill(notify_pid) after one call to
ForgetBackgroundWorker, but the postmaster has several more such calls.
Shouldn't they all notify the notify_pid? Should we move that
functionality into ForgetBackgroundWorker itself, so we can't forget
it again?

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2017-09-18 16:42:24 Re: src/test/subscription/t/002_types.pl hanging on particular environment
Previous Message Robert Haas 2017-09-18 16:16:42 Re: Re: [COMMITTERS] pgsql: Perform only one ReadControlFile() during startup.