Re: Add a test for "cannot truncate foreign table"

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>
Cc: Yugo NAGATA <nagata(at)sraoss(dot)co(dot)jp>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Add a test for "cannot truncate foreign table"
Date: 2022-07-07 15:33:00
Message-ID: 2983289.1657207980@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> writes:
> On 2022/06/30 10:48, Yugo NAGATA wrote:
>> When a foreign table has handler but doesn't support TRUNCATE,
>> an error "cannot truncate foreign table xxx" occurs. So, what
>> about adding a test this message output? We can add this test
>> for file_fdw because it is one of the such foreign data wrappers.

> Thanks for the patch! It looks good to me.
> I changed the status of this patch to ready-for-committer,
> and will commit it barring any objeciton.

This seems like a fairly pointless expenditure of test cycles
to me. Perhaps more importantly, what will you do when
somebody adds truncate support to that FDW? I don't think
there's an inherent reason for it to be read-only.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2022-07-07 15:48:20 Re: archive modules
Previous Message Fujii Masao 2022-07-07 15:25:24 Re: Add a test for "cannot truncate foreign table"