| From: | Nikolay Shaplov <dhyan(at)nataraj(dot)su> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, Álvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Robert Treat <rob(at)xzilla(dot)net>, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, Albe <laurenz(dot)albe(at)cybertec(dot)at>, Gurjeet Singh <gurjeet(at)singh(dot)im>, Will Storey <will(at)summercat(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Subject: | Re: vacuum_truncate configuration parameter and isset_offset |
| Date: | 2025-03-26 19:05:29 |
| Message-ID: | 2979004.Zkmt1EvEu4@thinkpad-pgpro |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
В письме от среда, 26 марта 2025 г. 21:43:42 MSK пользователь Robert Haas
написал:
> why is it worth arguing about?
I have full model of current reloptions and my patch unrolled in my head. They
have some harmony. (Mine has more harmony, but it is not the case).
isset_offset the way it is introduced breaks that harmony. Harmony worth it.
> I cannot see how this really makes any great difference.
git blame reloptions.c | grep "Robert Haas" | wc -l
112
git blame reloptions.c | grep Álvaro | wc -l
792
For me Alvary is the keeper of the concept of reloption. And he sees
difference. If he would said isset_offset is good, I will follow. Until then I
will follow my sense of harmony and code beauty as much as I can.
--
Nikolay Shaplov aka Nataraj
Fuzzing Engineer at Postgres Professional
Matrix IM: @dhyan:nataraj.su
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jacob Champion | 2025-03-26 19:09:14 | Re: [PoC] Federated Authn/z with OAUTHBEARER |
| Previous Message | Kirill Reshke | 2025-03-26 19:04:34 | Re: in BeginCopyTo make materialized view using COPY TO instead of COPY (query). |