Noah Misch <noah(at)leadboat(dot)com> writes:
> I am inclined to add an Assert(portal->status != PORTAL_ACTIVE) to emphasize
> that this is backup only. MarkPortalActive() callers remain responsible for
> updating the status to something else before relinquishing control.
No, I do not think that would be an improvement. There is no contract
saying that this must be done earlier, IMO.
regards, tom lane