Re: formatting.c

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: formatting.c
Date: 2014-09-13 03:48:03
Message-ID: 29756.1410580083@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Bruce Momjian <bruce(at)momjian(dot)us> writes:
> Is everyone OK with me renaming some variables, structures, and macros?
> It will make back-patching harder, but will allow us to properly maintain
> that file.

The back-patching problem could be addressed by back-patching the
renaming. If it's purely a mechanical thing, there should be minimal risk
no? I would claim that messed-up back-patches would have non-negligible
risk too, so you can't say that not back-patching is clearly safer.

Now, whether the renaming actually makes things any clearer is something
I reserve judgment on.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Arthur Silva 2014-09-13 03:59:47 Re: [REVIEW] Re: Compression of full-page-writes
Previous Message Bruce Momjian 2014-09-13 00:44:47 formatting.c