| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [COMMITTERS] pgsql: Preventive maintenance in advance of pgindent run. |
| Date: | 2017-05-17 17:06:26 |
| Message-ID: | 29715.1495040786@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
> Tom Lane wrote:
>> No, the previous setup hasn't been "in place for years". These programs
>> were only NLS-ified last fall.
> We use the same technique in other places such as pg_dump's help() too.
Meh. Well, I reverted the changes in question while we discuss it.
Changing the pgindent rule for such cases sounds kind of promising,
but will anyone pursue it?
(In any case, we should probably go ahead with the scheduled pgindent
run, and then we can consider a new run with new rules later; that
will ease seeing exactly what changes a new rule would make.)
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2017-05-17 17:16:00 | Re: [COMMITTERS] pgsql: Preventive maintenance in advance of pgindent run. |
| Previous Message | Tom Lane | 2017-05-17 17:04:08 | pgsql: Revert changes to pg_basebackup and pg_waldump usage() code. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Stephen Frost | 2017-05-17 17:07:22 | Re: [bug fix] PG10: libpq doesn't connect to alternative hosts when some errors occur |
| Previous Message | Robert Haas | 2017-05-17 16:58:55 | Re: [bug fix] PG10: libpq doesn't connect to alternative hosts when some errors occur |