Missed bet in toaster routines

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Jan Wieck <JanWieck(at)Yahoo(dot)com>
Cc: pgsql-hackers(at)postgreSQL(dot)org
Subject: Missed bet in toaster routines
Date: 2004-01-16 15:12:46
Message-ID: 29678.1074265966@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Wouldn't it be a win for heap_tuple_toast_attrs() to fall out quickly
if the tuple contains no varlena attributes? I'm thinking of adding
a test like

/* Nothing to do if tuple contains no varlena fields */
if ((newtup && !HeapTupleAllFixed(newtup)) ||
(oldtup && !HeapTupleAllFixed(oldtup)))
/* do existing processing */

This is a pretty cheap test (just checking a header flag) and saves lots
of useless scanning when it succeeds.

regards, tom lane

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Marc G. Fournier 2004-01-16 15:18:52 Re: nomenclature
Previous Message Tom Lane 2004-01-16 15:02:32 Re: [GENERAL] Bug and/or feature? Complex data types in tables...