Re: Triggers... Questions... Yes.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Tim Ellis <Tim(dot)Ellis(at)gamet(dot)com>
Cc: pgsql-admin(at)postgresql(dot)org
Subject: Re: Triggers... Questions... Yes.
Date: 2002-06-13 21:04:22
Message-ID: 29650.1024002262@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-admin

Tim Ellis <Tim(dot)Ellis(at)gamet(dot)com> writes:
> I just used Dezign for Databases and created a simple table in what it
> claimed was "ANSI Level 2" compliance with a one-up "autonum" column.

There is no such animal as "ANSI Level 2" SQL.

> create trigger transaction_autonum_inc
> before insert on transaction
> referencing new as n
> for each row
> set (n.autonum) = (select (max(autonum),0) + 1 from transaction);

Looking at SQL99 (that's ISO/IEC 9075-2:1999, Part 2: SQL/Foundation
if we have to get pedantic about it), there is something about a
"referencing" clause, which we do not have. However, the "set" command
shown here does not appear to be legal according to SQL99, so I'm not
planning to get excited about not having "referencing". There are a
number of missing features in our trigger stuff, and that one seems
right at the bottom of the list as far as adding useful functionality
goes.

BTW, what are they expecting "(max(autonum),0)" to do, other than draw a
syntax error? Perhaps there was supposed to be a COALESCE there?

Even if it worked or were standards-compliant, this approach to
implementing an autonumbering column would be brain dead in the extreme
--- you do *not* want to do a max() aggregate for every insert. Use
a sequence object instead...

regards, tom lane

In response to

Responses

Browse pgsql-admin by date

  From Date Subject
Next Message Ragnar Kjørstad 2002-06-13 21:21:57 Re: Indexes on separate disk ?
Previous Message Stephan Szabo 2002-06-13 20:59:17 Re: Triggers... Questions... Yes.