Re: [HACKERS] [ADMIN] invalid multibyte character for locale

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: Bjoern Metzdorf <bm(at)turtle-entertainment(dot)de>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [HACKERS] [ADMIN] invalid multibyte character for locale
Date: 2005-03-15 05:52:03
Message-ID: 2963.1110865923@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-admin pgsql-hackers pgsql-patches

Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> Tom Lane wrote:
>> Perhaps it would be reasonable to do something like this:
>>
>> #ifdef USE_WIDE_UPPER_LOWER
>> /*
>> * use wide char code only when max encoding length > one
>> * and we aren't in C locale
>> */
>> if (pg_database_encoding_max_length() > 1 &&
>> !lc_ctype_is_c())

> Tom, is this the fix you were thinking of? Seems like it would be a
> good improvement.

Please fix the comments not only the code ;-). Other than that,
this is exactly what I meant.

regards, tom lane

In response to

Browse pgsql-admin by date

  From Date Subject
Next Message Werner vd Merwe 2005-03-15 06:33:28 Re: Performance Question
Previous Message Bruce Momjian 2005-03-15 05:26:16 Re: [HACKERS] [ADMIN] invalid multibyte character for locale

Browse pgsql-hackers by date

  From Date Subject
Next Message Neil Conway 2005-03-15 05:53:06 Re: invalidating cached plans
Previous Message Tom Lane 2005-03-15 05:49:09 Re: invalidating cached plans

Browse pgsql-patches by date

  From Date Subject
Next Message Magnus Hagander 2005-03-15 16:54:28 Kerberos code overwrites it's own error message
Previous Message Bruce Momjian 2005-03-15 05:26:16 Re: [HACKERS] [ADMIN] invalid multibyte character for locale