Re: pgsql: Extend & revamp pg_bswap.h infrastructure.

Andres Freund <andres(at)anarazel(dot)de> writes:
> On 2017-09-30 12:17:06 -0400, Tom Lane wrote:
>> c.h will already have included <stdlib.h>. There might be some
>> value in this if we anticipated allowing freestanding use of this
>> header, but that won't happen because it depends on configure symbols.

> Well, it's not that obvious where the _byteswap_* functions are coming
> from on msvc. I guess we can just leave the comment
> /* In all supported versions msvc provides _byteswap_* functions in stdlib.h */
> there, but I see no harm in the current form either.

I'm OK with a comment like that, but I think we have a general style
guideline against headers duplicating stuff from c.h/postgres.h.
It just promotes confusion, IMO.

regards, tom lane