| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Stephen Frost <sfrost(at)snowman(dot)net> |
| Cc: | Andres Freund <andres(at)2ndquadrant(dot)com>, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, Naoya Anzai <anzai-naoya(at)mxu(dot)nes(dot)nec(dot)co(dot)jp>, pgsql-bugs(at)postgresql(dot)org, Akio Iwaasa <iwaasa(at)mxs(dot)nes(dot)nec(dot)co(dot)jp> |
| Subject: | Re: Memory-leak in BackgroundWriter(and Checkpointer) |
| Date: | 2013-06-04 18:21:20 |
| Message-ID: | 29609.1370370080@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
Stephen Frost <sfrost(at)snowman(dot)net> writes:
> * Tom Lane (tgl(at)sss(dot)pgh(dot)pa(dot)us) wrote:
>> I think the proposed fix is fine code-wise; the real problem here is
>> crummy commenting. GetRunningTransactionLocks isn't documented as
>> returning a palloc'd array, and why the heck do we have a long comment
>> about its implementation in LogStandbySnapshot?
> Certainly good questions and better comments would have helped here. I
> can go back and rework the patch either way.
I'm already working on back-patching the attached.
regards, tom lane
| Attachment | Content-Type | Size |
|---|---|---|
| leak.patch | text/x-patch | 3.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Stephen Frost | 2013-06-04 19:02:27 | Re: Memory-leak in BackgroundWriter(and Checkpointer) |
| Previous Message | Stephen Frost | 2013-06-04 18:05:25 | Re: Memory-leak in BackgroundWriter(and Checkpointer) |