From: | Scott Goodwin <scott(at)scottg(dot)net> |
---|---|
To: | Neil Conway <neilc(at)samurai(dot)com> |
Cc: | Christopher Kings-Lynne <chriskl(at)familyhealth(dot)com(dot)au>, pgsql-patches(at)postgresql(dot)org |
Subject: | Re: Patch to psql to allow SEARCH_PATH to be set from env |
Date: | 2004-02-10 22:04:56 |
Message-ID: | 295E0B91-5C15-11D8-91F4-000A95A0910A@scottg.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-patches |
Hi Neil,
I also saw an mm_alloc or something similar in another area of code.
I'll spend some time reading through the sources properly before I
attempt another mod. Thanks for the feedback -- much appreciated.
/s.
On Feb 10, 2004, at 3:24 PM, Neil Conway wrote:
> Scott Goodwin <scott(at)scottg(dot)net> writes:
>> If anyone cares to, I'd still like feedback on anything I could have
>> done better in this patch
>
> Since, you asked, two minor points: (1) palloc() is for memory
> allocation in the backend; use malloc() (or a wrapper like
> pg_malloc()) in frontend apps and libpq (2) naming variables like
> word1_Word2 is inconsistent with the surrounding code.
>
> -Neil
>
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2004-02-10 22:08:34 | Re: [PATCHES] Current-stream read for psql's \copy |
Previous Message | Bruce Momjian | 2004-02-10 21:41:03 | Re: [PATCHES] Current-stream read for psql's \copy |