From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Vladimir Churyukin <vladimir(at)churyukin(dot)com> |
Cc: | Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Improving inferred query column names |
Date: | 2023-02-22 21:38:51 |
Message-ID: | 295949.1677101931@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Vladimir Churyukin <vladimir(at)churyukin(dot)com> writes:
> It doesn't need to be perfect, but it needs to be consistent. So far you
> proposed a rule to replace () with _. What is the plan for expressions, how
> to convert them to names (with deduplication I guess?, because there could
> be 2 similar expressions mapped to the same name potentially).
I do not think we need to do anything for arbitrary expressions.
The proposal so far was just to handle a function call wrapped
around something else by converting to the function name followed
by whatever we'd emit for the something else. You cannot realistically
handle, say, operator expressions without emitting names that will
require quoting, which doesn't seem attractive.
And no, deduplication isn't on the table at all here.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Andrew Dunstan | 2023-02-22 22:03:13 | Re: pgindent vs. git whitespace check |
Previous Message | Tom Lane | 2023-02-22 21:34:44 | Re: PG 15 (and to a smaller degree 14) regression due to ExprEvalStep size |