| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Maciek Sakrejda <m(dot)sakrejda(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org, Hunaid Sohail <hunaidpgml(at)gmail(dot)com> |
| Subject: | Re: [PATCH] Add roman support for to_number function |
| Date: | 2024-09-08 21:44:20 |
| Message-ID: | 2957195.1725831860@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I wrote:
> * Further to Aleksander's point about lack of test coverage for
> the to_char direction, I see from
> https://coverage.postgresql.org/src/backend/utils/adt/formatting.c.gcov.html
> that almost none of the existing roman-number code paths are covered
> today. While it's not strictly within the charter of this patch
> to improve that, maybe we should try to do so --- at the very
> least it'd raise formatting.c's coverage score a few notches.
For the archives' sake: I created a patch and a separate discussion
thread [1] for that.
regards, tom lane
[1] https://www.postgresql.org/message-id/flat/2956175(dot)1725831136(at)sss(dot)pgh(dot)pa(dot)us
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2024-09-08 22:39:50 | Re: Test improvements and minor code fixes for formatting.c. |
| Previous Message | Tom Lane | 2024-09-08 21:32:16 | Test improvements and minor code fixes for formatting.c. |