Re: pgsql: Clean up some sloppy coding in repl_gram.y.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)2ndquadrant(dot)com>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Clean up some sloppy coding in repl_gram.y.
Date: 2014-02-03 14:20:24
Message-ID: 29475.1391437224@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Andres Freund <andres(at)2ndquadrant(dot)com> writes:
> On 2014-02-02 17:51:21 +0000, Tom Lane wrote:
>> I got interested in this because buildfarm member protosciurus has been
>> crashing in "bison repl_gram.y" since commit 858ec11. It's a long shot
>> that this will fix that, though maybe the missing trailing semicolon
>> has something to do with it?

> Whoa? This seems to have fixed protosciurus. That's an odd cause for a
> segfault in bison...

Hah, got lucky.

I have no idea why that fixed it. bison 1.875 on my old HPUX box
wasn't having a problem with repl_gram.y, so there must be something
not quite right about protosciurus' version.

regards, tom lane

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Fujii Masao 2014-02-03 14:24:07 pgsql: Make pg_basebackup skip temporary statistics files.
Previous Message Andres Freund 2014-02-03 14:14:16 Re: pgsql: Clean up some sloppy coding in repl_gram.y.