Re: BUG #17753: pg_dump --if-exists bug

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Noah Misch <noah(at)leadboat(dot)com>
Cc: David Rowley <dgrowleyml(at)gmail(dot)com>, justin(at)tonic(dot)ai, pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: BUG #17753: pg_dump --if-exists bug
Date: 2023-01-20 00:09:50
Message-ID: 294749.1674173390@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

I wrote:
> I think we need to do the attached, more or less. Also, although the
> given case seems to be new, we'd probably better back-patch, because
> I'm not convinced that there aren't other ways to reach this.

Ah --- we only need to back-patch to v15, because this business of
possibly having a comment in the dropStmt is new in a7a7be1f2.
That commit also added the existing exceptions for comments in
pg_backup_archiver.c ... but it missed the need to have special
cases for dropStmts too.

regards, tom lane

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message vignesh C 2023-01-20 05:24:58 Re: DROP DATABASE deadlocks with logical replication worker in PG 15.1
Previous Message Tom Lane 2023-01-19 22:22:15 Re: BUG #17753: pg_dump --if-exists bug