| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | David Rowley <dgrowleyml(at)gmail(dot)com> |
| Cc: | Justin Pryzby <pryzby(at)telsasoft(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: enable_resultcache confusion |
| Date: | 2021-07-12 13:38:48 |
| Message-ID: | 2945408.1626097128@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
David Rowley <dgrowleyml(at)gmail(dot)com> writes:
> On Mon, 12 Jul 2021 at 03:22, Justin Pryzby <pryzby(at)telsasoft(dot)com> wrote:
>> | This is useful if only a small percentage of rows is checked on
>> | the inner side and is controlled by <xref
>> | linkend="guc-enable-resultcache"/>.
> You might be right there, but I'm not too sure if I changed that that
> it might cause a mention of the rename to be missed in the changes
> since beta2 notes.
You need to change it, because IIUC that will be a dangling
cross-reference, causing the v14 docs to fail to build at all.
> Additionally, I was unsure about touching typedefs.list. In the patch
> I changed it, but wasn't too sure if that was the correct thing to do.
> In normal circumstances, i.e writing new code, I'd not touch it.
I'd suggest replacing it in typedefs.list, since there is unlikely to
be any further update to v14's copy otherwise, and even in HEAD I'm not
sure it'd get updated before we approach the v15 branch.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ronan Dunklau | 2021-07-12 13:59:42 | Re: [PATCH] Use optimized single-datum tuplesort in ExecSort |
| Previous Message | David Rowley | 2021-07-12 13:27:54 | Re: ATTACH PARTITION locking documentation for DEFAULT partitions |