From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Euler Taveira de Oliveira <euler(at)timbira(dot)com> |
Cc: | Itagaki Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Buffer usage in EXPLAIN and pg_stat_statements (review) |
Date: | 2009-09-29 02:50:28 |
Message-ID: | 29449.1254192628@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Euler Taveira de Oliveira <euler(at)timbira(dot)com> writes:
> Itagaki Takahiro escreveu:
>> Thanks. Except choice of words, can I think the basic architecture of
>> the patch is ok? The codes to handle global variables like ReadBufferCount
>> and GlobalReadBufferCount could be rewrite in cleaner way if we could
>> drop supports of log_{parser|planner|executor|statement}_stats.
>>
> Yes, it is. I'm afraid someone is relying on that piece of code.
If we have a better substitute, I think there'd be nothing wrong with
removing those features. They were never anything but pretty crufty
anyway, and they are *not* a compatibility issue because applications
have no direct way to access those stats. However, you'd have to be
sure that the substitute covers all the use-cases for the old stats
... which strikes me as a lot more territory than this patch has
proposed to cover.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2009-09-29 02:55:13 | Re: [PATCH] DefaultACLs |
Previous Message | Tom Lane | 2009-09-29 02:44:30 | Re: [PATCH] DefaultACLs |