From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> |
Cc: | pgsql-committers(at)postgresql(dot)org |
Subject: | Re: pgsql: Sync our copy of the timezone library with IANA release tzcode20 |
Date: | 2016-10-20 03:22:13 |
Message-ID: | 29391.1476933733@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> writes:
> On Thu, Oct 20, 2016 at 11:56 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Sync our copy of the timezone library with IANA release tzcode2016g.
> My compiler (Apple LLVM version 8.0.0 (clang-800.0.38)) doesn't like this:
> zic.c:427:53: error: implicit conversion from 'unsigned long long' to
> 'int' changes value from 18446744073709551615 to -1
> [-Werror,-Wconstant-conversion]
> int amax = nitems_max < SIZE_MAX ? nitems_max : SIZE_MAX;
> ~~~~ ^~~~~~~~
Hmm ... I wonder what the IANA guys think they're doing here?
There are no platforms on which INT_MAX is more than SIZE_MAX.
I think we can just take this out.
(My RHEL6 compiler didn't object to this, but I can reproduce
it on Mac.)
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2016-10-20 03:33:27 | pgsql: Another portability fix for tzcode2016g update. |
Previous Message | Thomas Munro | 2016-10-20 02:38:35 | Re: pgsql: Sync our copy of the timezone library with IANA release tzcode20 |