Re: broken comment justification logic in new pgindent

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: broken comment justification logic in new pgindent
Date: 2005-11-07 23:09:41
Message-ID: 29390.1131404981@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> Good point. I see the maximum length changed in this commit:
> revision 1.70
> date: 2004/10/02 01:10:58; author: momjian; state: Exp; lines: +1 -1
> Update length from 75 to 79.

> We were discussing some pgindent issues at that time on hackers, but I
> don't see any complaints about the length, so I am unsure why I modified
> it, but perhaps I received a private communication asking why it wasn't
> 79.

I remember that discussion, and I remember we agreed to update it to 79.
You're missing the point completely: the problem at hand is that
pgindent is failing to honor its width parameter in some situations.

> Anyway, I have updated the script to be 78,

This is just going to create a lot of gratutitous re-indents without
actually fixing the problem, because whatever bug is causing pgindent
to sometimes not honor the -l switch will still be there.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2005-11-07 23:16:58 Re: [HACKERS] Help with Array Function in C language...
Previous Message Tom Lane 2005-11-07 23:05:58 Re: Any advice about function caching?