Re: auto-sizing wal_buffers

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Greg Smith <greg(at)2ndquadrant(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: auto-sizing wal_buffers
Date: 2011-01-23 01:33:54
Message-ID: 29279.1295746434@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>> Barring screams of agony^W^W^Whelpful suggestions for how to code this
>> more neatly, I'll go ahead and commit this.

> The show_hook sucks, and is unnecessary, as is exposing the format
> function. Just set the GUC variable to the correct value.

Um: that was probably too brief. "Just set" means "use SetConfigOption".
As penance, I've committed the corrected patch.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2011-01-23 01:40:13 Re: Perl 5.12 complains about ecpg parser-hacking scripts
Previous Message Tom Lane 2011-01-23 00:22:26 Re: auto-sizing wal_buffers