| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Arthur Zakirov <zaartur(at)gmail(dot)com> |
| Cc: | Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, pgsql-hackers(at)postgresql(dot)org, Teodor Sigaev <teodor(at)sigaev(dot)ru> |
| Subject: | Re: CREATE TEXT SEARCH DICTIONARY segfaulting on 9.6+ |
| Date: | 2019-11-02 20:48:00 |
| Message-ID: | 29257.1572727680@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Arthur Zakirov <zaartur(at)gmail(dot)com> writes:
> On 2019/10/13 10:26, Tomas Vondra wrote:
>> So I think we need some sort of cross-check here. We certainly need to
>> make NISortDictionary() check the affix value is within AffixData
>> bounds, and error out when the index is non-sensical (maybe negative
>> and/or exceeding nAffixData).
> I agree, I attached the patch which do this. I also added couple
> asserts, tests and fixed condition in getAffixFlagSet():
> - if (curaffix > 0 && curaffix <= Conf->nAffixData)
> + if (curaffix > 0 && curaffix < Conf->nAffixData)
Looks reasonable to me, and we need to get something done before
the upcoming releases, so I pushed this. Perhaps there's more
that could be done later.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Stehule | 2019-11-02 20:56:17 | Re: dropdb --force |
| Previous Message | Pavel Stehule | 2019-11-02 20:38:21 | Re: dropdb --force |