From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
Cc: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: [PATCHES] Cleaning up unreferenced table files |
Date: | 2005-05-07 20:37:39 |
Message-ID: | 29232.1115498259@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
Heikki Linnakangas <hlinnaka(at)iki(dot)fi> writes:
> Maybe we should take a different approach to the problem:
> 1. Create new file with an extension to mark that it's not
> yet committed (eg. 1234.notcommitted)
This is pushing the problem into the wrong place, viz the lowest-level
file access routines, which will now all have to know about
.notcommitted status. It also creates race conditions --- think about
backend A trying to commit file 1234 at about the same time that
backend B is trying to flush some dirty buffers belonging to that file.
But most importantly, it doesn't handle the file-deletion case.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Treat | 2005-05-07 21:02:01 | Re: pgFoundry |
Previous Message | Joshua D. Drake | 2005-05-07 20:23:23 | Re: pgFoundry |
From | Date | Subject | |
---|---|---|---|
Next Message | Heikki Linnakangas | 2005-05-07 21:08:43 | Re: [PATCHES] Cleaning up unreferenced table files |
Previous Message | Heikki Linnakangas | 2005-05-07 18:51:17 | Re: [PATCHES] Cleaning up unreferenced table files |